From: Grant Likely <grant.likely@xxxxxxxxxxxx> Date: Thu, 4 Aug 2011 07:59:56 +0100 > Pull my tree now; there is a fix in there. I'm just emailing it now. Ugh, Grant :-/ So now you have APIs for finding information in the in-kernel copy of the device tree which are only available for flat DT platforms? Don't do that, please. It makes more sense instead to have this alias munger unconditionally work on the in-kernel copy after the device tree has been imported, and for all ways in which the tree can be imported. Anything else leads to fragmented interfaces for device driver writers. The bug is that this of_alias_scan() thing doesn't get a pointer to an allocator function. It needs one just like the __unflatten_device_tree() function does. In fact this points out that of_alias_scan() was only placed into one of the two FT unflattening sites, it needs to go into both as well as places that build the device tree from real OpenFirmware calls. And that makes an even stronger argument for adding an allocator function pointer arg to this thing. I think this change was stillborn when you committed it and you should have reviewed it more thoroughly and pushed back. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
