On 11-07-30 02:31 PM, Randy Dunlap wrote: > On Sat, 30 Jul 2011 13:41:52 -0400 Paul Gortmaker wrote: > >> On 11-07-30 03:25 AM, Heiko Carstens wrote: >>> Subject: [PATCH] s390: add missing module.h/export.h includes >>> >>> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx> >>> >>> Fix several compile errors on s390 caused by splitting module.h. >> >> Thanks, I'll put this on the branch today. > > Hi Paul, > > Did you see the 10 (I think) patches that I posted in reply to > Stephen's linux-next 20110729 announcement? > [that I did not copy you on :( ] > > They add linux/module.h or linux/export.h (and 1 for linux/sysfs.h) > to multiple files to fix build errors. > > You can see them as replies to https://lkml.org/lkml/2011/7/29/52 > or I can send them directly to you if you want me to do that... I'll grab them from existing e-mails as appropriate. For any ones that I flag as new files only existing in next, we'll need the maintainer to do the appropriate module.h addition. Since their tree won't have an export.h, they won't have any choice but to take the larger header for now. I plan on doing later sweeps to see if there are any lingering optimizations via "downsizing" more module.h users, so we'll convert any lingering few like this later. Thanks for chipping in, it turned out to be quite the task in the end. Paul. > > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html