On Fri, Jul 29, 2011 at 7:50 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> On 07/29/2011 02:45 AM, Sedat Dilek wrote:
>> [ CCing all people from 0416 patch ]
>>
>> OK, here a quick review and looking for suspicious commits:
> [snip]
>> -- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -14,6 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
>> proportions.o prio_heap.o ratelimit.o show_mem.o \
>> is_single_threaded.o plist.o decompress.o find_next_bit.o
>>
>> +lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
>> lib-$(CONFIG_MMU) += ioremap.o
>> lib-$(CONFIG_SMP) += cpumask.o
>>
>> So, I can rebuild next-201107{27,28} with
>> CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS=y and look again if the
>> build-breakage in binfmt_misc is gone.
>>
>> Any comments from x86 folk?
>
> I already noticed this and sent a fixup patch to Andrew. Looks like he
> never picked it up. The real fix is to change that lib-$(CONFIG... to
> obj-$(CONFIG...
>
> See https://lkml.org/lkml/2011/7/6/6 for the patch.
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>
>
NO, Andrew didn't do so [1] and that's why the appropriate patch [2]
in linux-next misses it, too.
Grr, your patch is from 05-Jul-2011...
- Sedat -
[1] http://userweb.kernel.org/~akpm/mmotm/broken-out/consolidate-config_debug_strict_user_copy_checks.patch
[2] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=4df97ff66a102a89ecfa2f88051e30bdd54ad864
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
