Hi Paul, After merging the moduleh tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/cell/spu_syscalls.c: In function 'spufs_calls_get': arch/powerpc/platforms/cell/spu_syscalls.c:42:2: error: implicit declaration of function 'try_module_get' arch/powerpc/platforms/cell/spu_syscalls.c: In function 'spufs_calls_put': arch/powerpc/platforms/cell/spu_syscalls.c:54:2: error: implicit declaration of function 'module_put' Caused by commit f7f927183dba ("powerpc: various straight conversions from module.h --> export.h"). This file should not be modified. From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Date: Fri, 29 Jul 2011 14:53:16 +1000 Subject: [PATCH] Partial revert of f7f927183dba "powerpc: various straight conversions from module.h --> export.h" This file needs module.h. Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> --- arch/powerpc/platforms/cell/spu_syscalls.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/cell/spu_syscalls.c b/arch/powerpc/platforms/cell/spu_syscalls.c index 60fc5ec..75530d9 100644 --- a/arch/powerpc/platforms/cell/spu_syscalls.c +++ b/arch/powerpc/platforms/cell/spu_syscalls.c @@ -22,7 +22,7 @@ */ #include <linux/file.h> #include <linux/fs.h> -#include <linux/export.h> +#include <linux/module.h> #include <linux/syscalls.h> #include <linux/rcupdate.h> -- 1.7.5.4 -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/ -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html