On Tue, 14 Jun 2011 10:13:57 -0600 Grant Likely wrote: > On Tue, Jun 14, 2011 at 09:12:11AM -0700, Randy Dunlap wrote: > > On Sun, 05 Jun 2011 20:45:43 -0700 Randy Dunlap wrote: > > > > > On 06/03/11 10:42, Grant Likely wrote: > > > > On Fri, Jun 3, 2011 at 11:18 AM, Mark Brown > > > > <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > >> On Fri, Jun 03, 2011 at 11:04:52AM -0600, Grant Likely wrote: > > > >> > > > >>> I ended up not pushing this one to Linus. Turns out it causes other > > > >>> breakage on other platforms that don't include include/linux/gpio.h. > > > >>> Since I don't have confidence that I'll be able to find all the > > > >>> offenders, I'm dropping it. I recommend making any drivers that are > > > >> > > > >> So, this originally came about because I pushed back on adding random > > > >> dependencies like this for features which are pretty much optional in > > > >> drivers - their use of GPIOs is totally optional and the dependencies > > > >> are just too fragile, leading to noise with all the randconfigs. It > > > >> seems better to get the architectures to keep up with enhancements to > > > >> gpiolib (or convert to it) than to have to worry about this in drivers. > > > > > > > > Fair enough. Randy, if you or someone else can check that all GPIOF_ > > > > users have the required #include <linux/gpio.h>, then I'm okay with > > > > this patch. > > > > > > OK, I'll look at that. > > > > Of the 70 files that use GPIOF_ macros: > > > > hdr missing in: ./arch/arm/mach-pxa/spitz_pm.c > > hdr missing in: ./arch/avr32/mach-at32ap/pio.c > > hdr missing in: ./arch/avr32/mach-at32ap/include/mach/portmux.h > > hdr missing in: ./arch/avr32/boards/hammerhead/setup.c > > hdr missing in: ./arch/avr32/boards/hammerhead/flash.c > > hdr missing in: ./arch/avr32/boards/mimc200/setup.c > > hdr missing in: ./arch/avr32/boards/atstk1000/setup.c > > hdr missing in: ./drivers/pcmcia/pxa2xx_vpac270.c > > > > > > > Do you have any examples of builds that failed with this patch? > > > > and would you merge patch(es) that add this header file to those source > > files? If not, I'll need to make 3 separate patches for them. That list of files above is incorrect. Bad grep pattern. Drop all of the avr32 files. Ending patch is small -- sending it soon. > Yes I would. I'm fine with it all being one patch. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
