On Fri, Jun 03, 2011 at 01:10:49PM +0200, David Sterba wrote: > On Wed, Jun 01, 2011 at 10:16:48AM -0500, Mitch Harder wrote: > > I've been playing around with resurrecting the basic sysfs > > capabilities that had been previously incorporated into btrfs. > > > > As it stands right now, it was relatively easy to re-implement sysfs > > as it was originally. However, that implementation of sysfs wasn't > > populated with much information (only total_blocks, blocks_used, and > > blocksize). > > Goffredo Baroncelli (CCed) posted a patch to enhance sysfs interface: > > https://patchwork.kernel.org/patch/308902/ > (http://www.spinics.net/lists/linux-btrfs/msg06777.html) > > > I also had to reverse a small portion of code that was in the last > > clean-up. > > Restoring the code should not be a problem, the cleanup was too eager > and I think a sysfs inteface would be good, not only for debugging > purposes or tuning. Indeed. There's a few parts of the balance API that would be significantly enhanced by being able to put things in sysfs. I could drop at least one (if not two) of the three ioctls if I had somewhere in sysfs to put the relevant files. Hugo. -- === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk === PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk --- The glass is neither half-full nor half-empty; it is twice as --- large as it needs to be.
Attachment:
signature.asc
Description: Digital signature
