On Tue, 24 May 2011 09:23:42 +0400 Dmitry Artamonow wrote:
> On 21:58 Mon 23 May , Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >
> > Make GPIOF_ defined values available even when GPIOLIB nor GENERIC_GPIO
> > is enabled by moving them to <linux/gpio.h>.
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Looks good.
>
> We probably may also want to move definition of struct gpio into
> include/linux/gpio.h to make things like this work as well:
>
> static struct gpio some_gpios[] = {
> { GPIO_BLAH, GPIOF_IN, "BLAH"},
> { GPIO_BLAH2, GPIOF_OUT_INIT_LOW, "BLAH2"},
> };
>
> static int some_init_function(void)
> {
> /* ... */
>
> gpio_request_array(some_gpios, ARRAY_SIZE(some_gpios));
>
> /* ... */
> }
>
> These gpio_request_one() and gpio_request_array() are quite handy, so I
> suppose more and more drivers will use it as we go...
That could help this one:
linux-next-20110524/include/linux/mfd/tps65910.h:774: error: field 'gpio' has incomplete type
and then add some way to handle (e.g.):
struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
=>
linux-next-20110524/drivers/gpio/tps65910-gpio.c:25: warning: type defaults to 'int' in declaration of '__mptr'
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
