On Tue, 24 May 2011 14:02:12 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20110523: when CONFIG_PRINTK is not enabled: net/core/filter.c:353: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' net/core/filter.c:353: warning: parameter names (without types) in function declaration net/core/filter.c:353: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE' net/core/filter.c:353: error: implicit declaration of function '__ratelimit' net/core/filter.c:353: error: '_rs' undeclared (first use in this function) Adding <linux/ratelimit.h> to <asm-generic/bug.h> causes other problems: In file included from linux-next-20110524/include/linux/thread_info.h:53, from linux-next-20110524/include/linux/preempt.h:9, from linux-next-20110524/include/linux/spinlock.h:50, from linux-next-20110524/include/linux/ratelimit.h:5, from linux-next-20110524/include/asm-generic/bug.h:5, from linux-next-20110524/arch/x86/include/asm/bug.h:38, from linux-next-20110524/include/linux/kernel.h:23, from linux-next-20110524/arch/x86/include/asm/percpu.h:44, from linux-next-20110524/arch/x86/include/asm/current.h:5, from linux-next-20110524/arch/x86/include/asm/processor.h:15, from linux-next-20110524/arch/x86/include/asm/atomic.h:6, from linux-next-20110524/include/linux/crypto.h:20, from linux-next-20110524/arch/x86/kernel/asm-offsets.c:8: linux-next-20110524/arch/x86/include/asm/thread_info.h:34: error: expected specifier-qualifier-list before 'mm_segment_t' In file included from linux-next-20110524/include/linux/thread_info.h:53, from linux-next-20110524/include/linux/preempt.h:9, from linux-next-20110524/include/linux/spinlock.h:50, from linux-next-20110524/include/linux/ratelimit.h:5, from linux-next-20110524/include/asm-generic/bug.h:5, from linux-next-20110524/arch/x86/include/asm/bug.h:38, from linux-next-20110524/include/linux/kernel.h:23, from linux-next-20110524/arch/x86/include/asm/percpu.h:44, from linux-next-20110524/arch/x86/include/asm/current.h:5, from linux-next-20110524/arch/x86/include/asm/processor.h:15, from linux-next-20110524/arch/x86/include/asm/atomic.h:6, from linux-next-20110524/include/linux/crypto.h:20, from linux-next-20110524/arch/x86/kernel/asm-offsets.c:8: linux-next-20110524/arch/x86/include/asm/thread_info.h:217: error: expected declaration specifiers or '...' before 'kernel_stack' linux-next-20110524/arch/x86/include/asm/thread_info.h:217: warning: data definition has no type or storage class linux-next-20110524/arch/x86/include/asm/thread_info.h:217: warning: type defaults to 'int' in declaration of 'DECLARE_PER_CPU' linux-next-20110524/arch/x86/include/asm/thread_info.h: In function 'current_thread_info': linux-next-20110524/arch/x86/include/asm/thread_info.h:222: error: implicit declaration of function 'percpu_read_stable' linux-next-20110524/arch/x86/include/asm/thread_info.h:222: error: 'kernel_stack' undeclared (first use in this function) --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html