On 02/22/2011 01:15 AM, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/wireless/rtlwifi/rtl8192cu/sw.c: In function 'rtl92cu_init_sw_vars': > drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:60: error: implicit declaration of function 'vmalloc' > drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:60: warning: assignment makes pointer from integer without a cast > drivers/net/wireless/rtlwifi/rtl8192cu/sw.c: In function 'rtl92cu_deinit_sw_vars': > drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:74: error: implicit declaration of function 'vfree' > > Caused by commit 442888c706e90634c4cc3441751b43115a7d8506 ("rtlwifi: > rtl8192cu: Add routines dm, fw, led and sw"). Missing an include of > linux/vmalloc.h. See Rule 1 in Documentation/SubmitChecklist. > > I added the following patch: > > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Date: Tue, 22 Feb 2011 17:29:04 +1100 > Subject: [PATCH] rtlwifi: include vmalloc.h for needed routines > > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > --- > drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c > index 4e937e0..c69861e 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c > @@ -27,6 +27,8 @@ > * > *****************************************************************************/ > > +#include <linux/vmalloc.h> > + > #include "../wifi.h" > #include "../core.h" > #include "../usb.h" I had gotten private mail yesterday about the missing vmalloc.h include. It will take me a while to set up an allyes configuration to find the other problems. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html