On Tue, Feb 01, 2011 at 06:19:56PM +0100, Patrick McHardy wrote: > Am 01.02.2011 18:05, schrieb Randy Dunlap: > > On 02/01/11 02:04, Simon Horman wrote: > >> On Tue, Feb 01, 2011 at 03:06:37PM +1100, Simon Horman wrote: > >>> On Mon, Jan 31, 2011 at 04:50:09PM -0800, Randy Dunlap wrote: > >>>> On Tue, 1 Feb 2011 11:14:11 +1100 Simon Horman wrote: > >>>> > >>>>> Hi, > >>>>> > >>>>> This short patch series addresses two linux-next build problems > >>>>> raised by Randy Dunlap: > >>>>> > >>>>> * net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int' > >>>>> * ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] > >>>>> ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined! > >>>>> > >>>>> The remainder of the changset is cleanups that I noticed along the way. > >>>> > >>>> These 4 patches build successfully for me. > >>>> However, I do see these warnings (sorry I missed them earlier): > >>>> > >>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup() > >>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup() > >>> > >>> Thanks, I'll look into that. I will be travelling for a good portion of the > >>> next day and a bit so I apologise in advance if that delays my next patch. > >> > >> Hi, > >> > >> I the following patch seems to be the right fix for this to me. > >> I will send an amended pull request. > >> > >> IPVS: Remove ip_vs_sync_cleanup from section __exit > >> > >> ip_vs_sync_cleanup() may be called from ip_vs_init() on error > >> and thus needs to be accesible from section __init > >> > >> Reporte-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Reported-by: > > > >> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> > > > > Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Thanks, since Simon is travelling, I'll apply the patches now > with your and Hans's Acks and will push them to Dave later. Thanks, I've finished travelling now :-) -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
