On Fri, Jan 14, 2011 at 4:22 PM, <Narendra_K@xxxxxxxx> wrote: > On Thu, Jan 13, 2011 at 09:33:56PM +0530, K, Narendra wrote: >> On Thu, Jan 13, 2011 at 09:25:56PM +0530, Jesse Barnes wrote: >> > On Wed, 12 Jan 2011 22:23:55 -0500 (EST) >> > Len Brown <lenb@xxxxxxxxxx> wrote: >> > > > So there's no other ACPI code that depends on this function? ÂI'd hate >> > > > to make PCI depend on NLS, so assuming ACPI doesn't need it (in which >> > > > case the select or depend should be there), I guess it should be pulled >> > > > into a common file that will always be included. >> > > >> > > No, nothing in the ACPI code uses utf16s_to_utf8s. >> > > >> > > I don't know anything about NLS, but it appears to be >> > > something that file systems (befs, cifs, fat, hfs, isofs, jfs, etc) >> > > use to to support native languages. >> > > >> > > BTW. I don't understand why pci-label.o appears twice above. >> > > It used to be just the 2nd one, that depends on CONFIG_DMI. >> > >> > Ok, I'll drop this patch for now then since I haven't seen a fix yet >> > and need to get Linus the rest of the changes. >> >> Jesse, >> >> I just compile tested a fix on the following lines without any failure. >> If it is acceptable, i will send a patch in half an hour. It builds >> > > Hello, > > This patch addresses the build failure described in this thread by > compiling fs/nls/nls_base.c always into vmlinux, thus making the base > nls functions available always. > > Please consider this patch for inclusion if there are no concerns with > this approach. > So NLS is built always? You thought of embedded devices like router platforms which want to reduce their kernel (size) by not building NLS? - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html