2010/12/27 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>: > Hi all, > > On Thu, 23 Dec 2010 22:36:34 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: >> >> After merging the final tree, today's linux-next build (powerpc allyesconfig) >> failed like this: >> >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_enable': >> drivers/input/keyboard/tc3589x-keypad.c:239: error: 'keypad' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_disable': >> drivers/input/keyboard/tc3589x-keypad.c:268: error: 'keypad' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c: At top level: >> drivers/input/keyboard/tc3589x-keypad.c:448: error: expected ',' or ';' before 'static' >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_init': >> drivers/input/keyboard/tc3589x-keypad.c:460: error: 'tc3589x_keypad_driver' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_exit': >> drivers/input/keyboard/tc3589x-keypad.c:466: error: 'tc3589x_keypad_driver' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c:466: warning: 'return' with a value, in function returning void >> >> Caused by commit 1967733650dac41c93954a187246c91430c4a94f >> ("input/tc3589x: add tc3589x keypad support"). > > This error is still there, so I reverted the above commit for today. Ooopsie, thanks for noticing. I've reverted this driver and pushed now. This driver will likely have to wait for the next merge window. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html