On Fri, 3 Dec 2010, Stephen Rothwell wrote:
> Hi James,
>
> Commit 676dac4b1bee0469d6932f698aeb77e8489f5861 ("This patch adds a new
> security attribute to Smack called") that was added to your tree today
> has no Signed-off-by and could do with a better summary line in the
> commit message. And probably a better explanation of what it does.
>
> Makes me wonder about the level of review it received :-(
I noticed it and pointed it out to Casey, who is converting over to
pushing git to me instead of posting patch sets.
If I'm pulling from someone's repo, it means I trust them enough not to
need to personally review each line of change.
Can this be fixed with git-commit --amend ?
- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
