I have some bones to gnaw. Not specific to this patch ;) On Fri, 29 Oct 2010 16:54:26 +0200 <michael.hennerich@xxxxxxxxxx> wrote: > Subject: [PATCH] video: backlight: adp8870: Fix warn_unused_result warning reported by Stephen Rothwell Lots of people are doing this "video: backlight: adp8870:" thing lately. And it's good, but why not just use "drivers/video/backlight/adp8860_bl.c" to identify the affected susbsytem/file/etc? It's simple and uniform. It's not always the appropriate thing to do, but replacing the /'s with ": " seems rather random and pointless. Secondly, no, the point of this patch is not to fix a warn_unused_result() warning! The patch actually fixes a bug: the code wasn't checking the strict_strtoul() return value. The warning is simply what alerted us to the bug. So I renamed this patch to drivers/video/backlight/adp8860_bl.c: check strict_strtoul() return value -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
