On Thu, 23 Sep 2010 08:13:50 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote: > On Thu, 23 Sep 2010 07:14:33 -0700 Greg KH wrote: > > > On Thu, Sep 23, 2010 at 02:20:18PM +1000, Stephen Rothwell wrote: > > > Hi Greg, > > > > > > After merging the tty tree, today's linux-next build (x86_64 > > > allmodconfig) failed like this: > > > > > > drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function) > > > > > > Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount > > > changeover for other main devices"). > > > > > > Please build test (especially the trivial "cut and paste" changes) ... > > > > > > I have reverted that commit for today. > > > > Ick, sorry about that. Alan, care to send a fixup patch for this? > > > So developers and maintainers are not doing allmodconfig builds? I try to make sure I build all the drivers I touch - I screwed that one up. Lots of -next trees build for allmodconfig and not other configs so all doing the same build isn't neccessarily good. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html