* Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi Yinghai, > > On Tue, 14 Sep 2010 16:00:06 -0700 Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > > > > Also, we may need to remove all extern and __init and __initdata etc in .h files. > > > > please check > > > > [PATCH -v3] memblock: Fix section mismatch warning > > > > Use __init_memblock to replace __init, and remove __init in memblock.h > > > > -v2: more with memblock_is_meory() > > -v3: remove __init for function declaring in memblock.h. Pointed out by Stephen. > > > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > Signed-off-by: Yinghai Lu <Yinghai@xxxxxxxxxx> > > This version fixes all the warnings for me. So if you put the "extern"s > back, you can add: > > Tested-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Yinghai, mind posting the final version of the patch as a standalone posting, with a proper changelog, and with the extern issue fixed as well, plus all Reported-by and Tested-by tags added? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html