On Thu, 02 Sep 2010 06:32:54 +0200, Greg KH <greg@xxxxxxxxx> wrote:
On Thu, Sep 02, 2010 at 01:54:50PM +1000, Stephen Rothwell wrote:Hi Greg, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/usb/gadget/nokia.c:244: error: unknown field 'bind' specified in initializer drivers/usb/gadget/nokia.c:244: warning: initialization makes integer from pointer without a cast drivers/usb/gadget/nokia.c:244: error: initializer element is not computable at load time drivers/usb/gadget/nokia.c:244: error: (near initialization for 'nokia_driver.needs_serial') drivers/usb/gadget/nokia.c: In function 'nokia_init': drivers/usb/gadget/nokia.c:250: error: implicit declaration of function 'usb_composite_register' Caused by commit cc604fa9db859b7d6899de807d6bd8df80fc0a1a ("usb gadget: don't save bind callback in struct usb_configuration"). The 'bind' and 'usb_composite_register' references above were added before 2.6.34-rc1 but missed in this patch. Please make every attempt to (at least) build every file that gets modified when testing a patch. (and grep is your friend) I have used the usb tree from next-20100901 for today.Sorry about that, my build didn't catch this. I'll fix it up tomorrow.
I'm already working on updated patch. I'll send it in an hour or so. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
