Hi Randy, On Tuesday 10 August 2010 16:48:57 Randy Dunlap wrote: > On 08/10/10 05:16, Laurent Pinchart wrote: > > On Monday 09 August 2010 19:55:20 Randy Dunlap wrote: > >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > >> > >> The USB gadget webcam driver uses V4L2 interfaces, so it should depend > >> on VIDEO_V4L2 instead of VIDEO_DEV. This fixes a lot of build errors > >> when V4L2 is not enabled: > >> > >> ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] > >> undefined! ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] > >> undefined! ERROR: "video_device_release" > >> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "video_usercopy" > >> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "v4l2_event_dequeue" > >> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: > >> "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] > >> undefined! ERROR: "video_unregister_device" > >> [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined! > >> ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined! > > > > All those symbols should be defined when VIDEO_DEV is selected. > > > >> ERROR: "v4l2_ctrl_fill" [drivers/media/video/v4l2-common.ko] undefined! > >> ERROR: "v4l2_ctrl_get_menu" [drivers/media/video/v4l2-common.ko] > >> undefined! > > > > Those 2 symbols require VIDEO_V4L2 but are not used by the webcam gadget > > driver. > > > >> ERROR: "v4l2_device_unregister_subdev" > >> [drivers/media/video/v4l2-common.ko] undefined! > >> ERROR: "v4l2_device_register_subdev" > >> [drivers/media/video/v4l2-common.ko] undefined! > > > > Those two symbols should be defined when VIDEO_DEV is selected. They are > > not used by the webcam gadget driver. > > Summary: I should drop this patch and look elsewhere for the problem, > Right? I think the problem comes from somewhere else, yes. Your patch won't hurt, but I don't see how it could fix the problem either. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
