On Tuesday 13 July 2010, Stephen Rothwell wrote: > Overlapping additions. I fixed it up (see below) and carry the fix as necessary. > > I was not sure if the kparam_(un)block_sysfs_write() calls needed to be > surrounded by the (un)lock_kernel() calls or vice verse. Either way should be fine, since the BKL does not suffer from AB-BA deadlocks with mutexes. I would generally recommend making the BKL the outermost lock to make it easier to conver to a mutex. That is how you did it too. Thanks, Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html