Hi Richard, After merging the backlight tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/video/backlight/adp8860_bl.c: In function 'adp8860_led_probe': drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of function 'kzalloc' drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes pointer from integer without a cast drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of function 'kfree' drivers/video/backlight/adp8860_bl.c: In function 'adp8860_probe': drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes pointer from integer without a cast drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to function 'backlight_device_register' Caused by commit 6f1a02240dba279a389fd4a4138445bd3f13f67f ("backlight: new driver for the ADP8860 backlight parts"). Use of kzalloc or kfree requires including linux/slab.h (see Rule 1 in Documentation/SubmitChecklist) and the prototype of backlight_device_register changed before v2.6.34-rc2. Was this even build tested? I have used the version of the backlight tree from next-20100507 for today. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/
Attachment:
pgpoEsS70AUW6.pgp
Description: PGP signature