On Tue, Mar 16, 2010 at 09:33:55AM +1100, Stephen Rothwell wrote: > Hi Frederic, > > On Mon, 15 Mar 2010 23:17:22 +0100 Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote: > > > > perf_arch_fetch_caller_regs() is exported for the overriden x86 > > version, but not for the generic weak version. > > As a general rule, weak functions should have their symbol exported > ^ > "not" Ooh, right. > > in the same file they are defined. > > > > So let's export it on trace_event_perf.c as it is used by trace > > events only. > > Otherwise, looks good (though I haven't tested it). I've tested with some trace event built as module and it looks fine so far. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
