* Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote: > On 02/25/10 13:27, Arnd Bergmann wrote: > > The pktcdvd driver uses proper locking and does not need the > > BKL in the ioctl and llseek functions of the character device, > > so kill both. Moving the compat_ioctl handling from common code > > into the driver itself fixes build problems when CONFIG_BLOCK is > > disabled. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > --- > > On Thursday 25 February 2010, Randy Dunlap wrote: > >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > >> > >> fs/compat_ioctl.c should omit pktcdvd.h and its ioctl when CONFIG_BLOCK > >> is not enabled. This fixes these build errors: > >> > >> In file included from fs/compat_ioctl.c:105: > >> include/linux/pktcdvd.h:166: error: field 'read_queue' has incomplete type > >> include/linux/pktcdvd.h:167: error: field 'write_queue' has incomplete type > >> include/linux/pktcdvd.h:207: error: field 'orig_bios' has incomplete type > >> make[2]: *** [fs/compat_ioctl.o] Error 1 > > > > How about this one instead, cleaning pktcdvd ioctl handling up for good? > > OK, that works too. > > Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> FYI, this build bug now triggers upstream too - none of the fixes was applied. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
