Hi Samuel, On Mon, Nov 23, 2009 at 01:26:07PM +0100, Samuel Ortiz wrote: > Hi Dmitry, > > On Mon, Nov 23, 2009 at 02:35:03PM +1100, Stephen Rothwell wrote: > > Hi Samuel, > > > > Today's linux-next build (x86_64 allmodconfig) failed like this: > > > > drivers/power/pcf50633-charger.c: In function 'pcf50633_mbc_get_usb_online_status': > > drivers/power/pcf50633-charger.c:147: error: 'struct pcf50633' has no member named 'mbc_pdev' > > > > Caused by commit 4c2e3bacc050f0ebf884954bb007616c162564cd ("mfd: pcf50633 > > - fix error handling during probe") from the mfd tree interacting with > > commit c329795052aa339850a45fab649ab97a36905136 ("pcf50633: Query charger > > status directly") from the battery tree. > Could we split the above fix so that we get back to the: > > struct platform_device *rtc_pdev; > struct platform_device *mbc_pdev; > struct platform_device *adc_pdev; > struct platform_device *input_pdev; > struct platform_device *regulator_pdev[PCF50633_NUM_REGULATORS]; > > structure ? We can move to the index based structure after the next merge > window. That would make my life easier in terms of tree dependencies. > If you dont have time to do this change, I'll do it some time this week. > Please feel free to drop or reschedule the patch as you see fit. I don't have any problem if it will go in later. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html