Hi all, Today's linux-next merge of the tip tree got a conflict in arch/x86/kernel/kgdb.c between commit 1cde88814e04c3b2bbe60e20c0927a0b4e1748ab ("kgdb,i386: Fix corner case access to sp with NMI watch dog exception") from the kgdb tree and commit 5ca6c0ca5dbf105d7b0ffdae2289519982189730 ("x86: use kernel_stack_pointer () in kgdb.c") from the tip tree. I fixed it up (see below) but would like people to check as I am not sure of the fix. I can carry this as necessary. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx diff --cc arch/x86/kernel/kgdb.c index e9afae9,3310d84..0000000 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c @@@ -85,15 -85,9 +85,15 @@@ void pt_regs_to_gdb_regs(unsigned long gdb_regs[GDB_DS] = regs->ds; gdb_regs[GDB_ES] = regs->es; gdb_regs[GDB_CS] = regs->cs; - gdb_regs[GDB_SS] = __KERNEL_DS; gdb_regs[GDB_FS] = 0xFFFF; gdb_regs[GDB_GS] = 0xFFFF; + if (user_mode_vm(regs)) { + gdb_regs[GDB_SS] = regs->ss; + gdb_regs[GDB_SP] = regs->sp; + } else { + gdb_regs[GDB_SS] = __KERNEL_DS; - gdb_regs[GDB_SP] = (unsigned long)®s->sp; ++ gdb_regs[GDB_SP] = kernel_stack_pointer(regs); + } #else gdb_regs[GDB_R8] = regs->r8; gdb_regs[GDB_R9] = regs->r9; @@@ -106,8 -100,8 +106,8 @@@ gdb_regs32[GDB_PS] = regs->flags; gdb_regs32[GDB_CS] = regs->cs; gdb_regs32[GDB_SS] = regs->ss; - gdb_regs[GDB_SP] = regs->sp; -#endif + gdb_regs[GDB_SP] = kernel_stack_pointer(regs); +#endif } /** -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html