[PATCHv2] qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Randy Dunlap noted:

  when CONFIG_MODULES=n:

	drivers/scsi/qla2xxx/qla_os.c:2685: error: dereferencing pointer to incomplete type

  in

	kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj,
		KOBJ_CHANGE, envp);

Trigger kobject event on the 'struct device' hanging off the pci_dev.

Signed-off-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
---

> On Fri, 11 Sep 2009, Andrew Vasquez wrote:
> 
> > The struct device's kobj from pdev->dev?
> > 
> > My udev-foo is pathetic, so how exactly would that get multiplexed at
> > the udev side?
> > 
> > 	KERNEL=="???", SUBSYSTEM=="???", ACTION=="change", RUN+="qla2xxx_udev.sh"
> 
> Ok, udevadm helps a bit...  Let me see if I can convert this uevent
> off of:
> 
> 	kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp);
> 
> to something meaningful:
> 
> 	UEVENT[1252714722.263731] change
> 	/devices/pci0000:17/0000:17:08.0/0000:1e:00.0 (pci)
> 	ACTION=change
> 	DEVPATH=/devices/pci0000:17/0000:17:08.0/0000:1e:00.0
> 	SUBSYSTEM=pci
> 	FW_DUMP=6
> 	DRIVER=qla2xxx
> 	PHYSDEVBUS=pci
> 	PHYSDEVDRIVER=qla2xxx
> 	PCI_CLASS=C0400
> 	PCI_ID=1077:2532
> 	PCI_SUBSYS_ID=1077:015C
> 	PCI_SLOT_NAME=0000:1e:00.0
> 	MODALIAS=pci:v00001077d00002532sv00001077sd0000015Cbc0Csc04i00
> 	SEQNUM=3574

Ok, with the kobject_uevent_env() change and the udev-rule modified to:

	SUBSYSTEM=="pci", ENV{DRIVER}="qla2xxx", ACTION=="change", RUN+="qla2xxx_udev.sh"

we're working again.

This seem reasonable?

Thanks, AV

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 29396c0..369a270 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code)
 		/* do nothing */
 		break;
 	}
-	kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj,
-	    KOBJ_CHANGE, envp);
+	kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp);
 }
 
 void
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux