Joe, Patches look fine, I reviewed and tested these patches on latest davem-net-next-2.6 sources. Acked-by: Sreenivasa Honnur <sreenivasa.honnur@xxxxxxxxxxxx> Regs srini -----Original Message----- From: Joe Perches [mailto:joe@xxxxxxxxxxx] Sent: Thursday, August 27, 2009 4:18 AM To: David Miller Cc: netdev@xxxxxxxxxxxxxxx; Anil Murthy; Sreenivasa Honnur; Sivakumar Subramani; Rastapur Santosh; Ramkrishna Vepa; akpm@xxxxxxxxxxxxxxxxxxxx; linux-next@xxxxxxxxxxxxxxx Subject: Re: [PATCH 0/9] drivers/net/s2io.c: Cleanups On Wed, 2009-08-26 at 15:33 -0700, David Miller wrote: > From: Joe Perches <joe@xxxxxxxxxxx> > Date: Mon, 24 Aug 2009 20:29:39 -0700 > > Just a few cleanups, compiled, untested. No hardware. > > s2io.c: Use const for strings > > s2io.c: Shorten code line length by using intermediate pointers > > s2io.c: Use calculated size in kmallocs > > s2io.c: use kzalloc > > s2io.c: Make more conforming to normal kernel style > > s2io.c: convert printks to pr_<level> > > s2io.c: fix spelling explaination > > s2io.c: Standardize statistics accessors > > s2io.c: Convert skipped nic->config.tx_cfg[i]. to tx_cfg-> > > Since this is a pretty serious set of cleanups, I'd like to let the > S2IO driver folks have some time to look at this and at least have a > chance to ACK/NACK them. No worries. That's fine. It's only cleanups. I haven't heard from them though and they haven't submitted or signed a patch for s2io in over a year. Hey! Neterion people! Is anybody home? -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
