Hi Jiri,
Today's linux-next build (sparc32 defconfig) failed like this:
drivers/hid/hid-core.c:862:34: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
drivers/hid/hid-core.c: In function 'hid_process_event':
drivers/hid/hid-core.c:862: error: 'hid_dump_input' undeclared (first use in this function)
drivers/hid/hid-core.c:862: error: (Each undeclared identifier is reported only once
drivers/hid/hid-core.c:862: error: for each function it appears in.)
drivers/hid/hid-core.c:984:68: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
drivers/hid/hid-core.c: In function 'hid_set_field':
drivers/hid/hid-core.c:984: error: 'hid_dump_input' undeclared (first use in this function)
drivers/hid/hid-core.c: In function 'hid_input_report':
drivers/hid/hid-core.c:1090: error: 'HID_DEBUG_BUFSIZE' undeclared (first use in this function)
Caused by commit cd667ce24796700e1a0e6e7528efc61c96ff832e ("HID: use
debugfs for events/reports dumping") which modified the prototype for
hid_dump_input, but not the !CONFIG_DEBUG_FS version. It also added
HID_DEBUG_BUFSIZE when CONFIG_DEBUG_FS, but used it otherwise.
I have reverted that commit for today (along with commit
a635f9dd83f3382577f4544a96df12356e951a40 ("HID: use debugfs for report
dumping descriptor") which doesn't build without the other one).
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
Attachment:
pgpRTYpEnKcLp.pgp
Description: PGP signature
