Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx> writes: > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: >> Hi Subrata, >> >> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx> wrote: >> > >> > /* Find the TBI PHY. If it's not there, we don't support SGMII */ >> > - ph = of_get_property(np, "tbi-handle", NULL); >> > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); >> >> You don't need this cast because of_get_property() returns "void *". > > Stephen, > > True. But without this gcc complains: > > CC [M] drivers/net/ucc_geth.o > drivers/net/ucc_geth.c: In function ‘ucc_geth_probe’: > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers > from pointer target type ph should be declared const phandle *. Look at other uses of of_get_property. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
