Hi Michael, >On Thu, 2009-06-11 at 12:03 +1000, Michael Ellerman wrote: >On Thu, 2009-06-11 at 07:26 +0530, Subrata Modak wrote: > > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: > > > Hi Subrata, > > > > > > On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > /* Find the TBI PHY. If it's not there, we don't support SGMII */ > > > > - ph = of_get_property(np, "tbi-handle", NULL); > > > > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); > > > > > > You don't need this cast because of_get_property() returns "void *". > > > > Stephen, > > > > True. But without this gcc complains: > > > > CC [M] drivers/net/ucc_geth.o > > drivers/net/ucc_geth.c: In function â??ucc_geth_probeâ??: > > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers from pointer target type > ^^^^^^^^^^^ > > And what does that warning actually mean? > > Your cast actually introduces a bug. > Ok fine. Here is a revised patch. Subject: [PATCH][Resend][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Reference(s): http://lkml.org/lkml/2009/6/4/241, http://lkml.org/lkml/2009/6/10/338, Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx> --- --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 20:53:25.000000000 -0500 @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { + struct device_node *mdio; + phandle *ph; struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct net_device *dev = NULL; --- Regards-- Subrata > cheers -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
