>On Thu, 2009-06-04 at 22:40 +0200, Geert Uytterhoeven wrote: >On Thu, Jun 4, 2009 at 20:07, Greg KH <greg@xxxxxxxxx> wrote: > > On Thu, Jun 04, 2009 at 07:01:32PM +0530, Subrata Modak wrote: > >> CC [M] drivers/staging/comedi/drivers.o > >> drivers/staging/comedi/drivers.c: In function â??comedi_buf_allocâ??: > >> drivers/staging/comedi/drivers.c:496: error: â??PAGE_KERNEL_NOCACHEâ?? undeclared (first use in this function) > >> drivers/staging/comedi/drivers.c:496: error: (Each undeclared identifier is reported only once > >> drivers/staging/comedi/drivers.c:496: error: for each function it appears in.) > >> make[3]: *** [drivers/staging/comedi/drivers.o] Error 1 > >> make[2]: *** [drivers/staging/comedi] Error 2 > >> make[1]: *** [drivers/staging] Error 2 > >> make: *** [drivers] Error 2 > >> > >> Is it still normal to expect this failure ? > > > > No. > > > >> I reported them long back during April: > >> http://www.gossamer-threads.com/lists/linux/kernel/1065227, > > > > Yes, and I took some patches that were supposed to fix this. I can't > > duplicate this here, care to send a patch that would fix it? I tried this. But, with some catch. â??PAGE_KERNEL_NOCACHEâ?? seems to be the choice for majority of architectures like frv, m32r, sh, x86, etc, as Geert mentions below. However, i believe POWERPC defines it as â??PAGE_KERNEL_NCâ?? found at arch/powerpc/include/asm/pte-common.h. Paul/Banjamin, Can you please confirm this ? The below patch fixes the build error. Signed-off-by: Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx> --- --- linux-2.6.30-rc8/drivers/staging/comedi/drivers.c.orig 2009-06-05 12:46:35.000000000 -0500 +++ linux-2.6.30-rc8/drivers/staging/comedi/drivers.c 2009-06-05 13:03:31.000000000 -0500 @@ -43,9 +43,13 @@ #include <linux/vmalloc.h> #include <linux/cdev.h> #include <linux/dma-mapping.h> - #include <asm/io.h> #include <asm/system.h> +#ifdef __powerpc64__ +#include <asm/pte-common.h> +#else +#include <asm/pgtable.h> +#endif static int postconfig(struct comedi_device *dev); static int insn_rw_emulate_bits(struct comedi_device *dev, struct comedi_subdevice *s, @@ -492,8 +496,13 @@ int comedi_buf_alloc(struct comedi_devic } if (i == n_pages) { async->prealloc_buf = +#ifdef __powerpc64__ + vmap(pages, n_pages, VM_MAP, + PAGE_KERNEL_NC); +#else vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE); +#endif } if (pages) { vfree(pages); --- Regards-- Subrata > PAGE_KERNEL_NOCACHE is defined on a few architectures only, namely > frv, m32r, mn10300, sh, and x86[*]. On all others, it will fail. > > [*] Interestingly, sparc refers to it in one of its include files, > without providing a > definition, Probably that code is unused. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
