On Mon, May 25 2009, Stephen Rothwell wrote:
> Hi Neil,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> drivers/md/raid0.c: In function 'create_strip_zones':
> drivers/md/raid0.c:243: error: 'struct request_queue' has no member named 'hardsect_size'
>
> Caused by commit e1defc4ff0cf57aca6c5e3ff99fa503f5943c1f1 ("block: Do
> away with the notion of hardsect_size") from the block tree interacting
> with commit 131e4477401ae76a9cbe8539e4b7819e04cfba36 ("md: raid0: chunk
> size check in raid0_run") from the md tree.
Martin, this is starting to look like a disaster :-(
>
> I applied the following patch.
> --
> Cheers,
> Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
>
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index b8a0747..0bf275d 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -240,7 +240,7 @@ static int create_strip_zones(mddev_t *mddev)
> * now since we have the hard sector sizes, we can make sure
> * chunk size is a multiple of that sector size
> */
> - if (mddev->chunk_size % mddev->queue->hardsect_size) {
> + if (mddev->chunk_size % queue_logical_block_size(mddev->queue)) {
> printk(KERN_ERR "%s chunk_size of %d not valid\n",
> mdname(mddev),
> mddev->chunk_size);
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
