Stephen Rothwell wrote: > On Fri, 22 May 2009 14:48:47 +0900 Paul Mundt <lethal@xxxxxxxxxxxx> wrote: >> On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote: >>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >>> >>> Build fails when CONFIG_I2C=n, so handle that case in the if block: >>> >>> drivers/built-in.o: In function `v4l2_device_unregister': >>> (.text+0x157821): undefined reference to `i2c_unregister_device' >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> This patch still has not been applied as far as I can tell, and builds >> are still broken as a result, almost 2 weeks after the fact. > > In fact there has been no updates to the v4l-dvb tree at all since > May 11. Mauro? I got an 'hg' autocommit message for the patch on May-11, but that's all I've seen/heard about it. I'm really concerned about how slowly patches are merged for linux-next trees... and not just for drivers/media/ > I have reverted the patch that caused the build breakage ... (commit > d5bc7940d39649210f1affac1fa32f253cc45a81 "V4L/DVB (11673): v4l2-device: > unregister i2c_clients when unregistering the v4l2_device"). > > [By the way, an alternative fix might be to just define > V4L2_SUBDEV_FL_IS_I2C to be zero if CONFIG_I2C and CONFIG_I2C_MODULE are > not defined (gcc should then just elide the offending code).] -- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
