On Wed, May 20, 2009 at 01:41:41PM +0400, Alexander Beregalov wrote:
> Hi Borislav,
>
> What do you think about this fix?
> I have no idea what value should be for the cpu variable.
This patch should be better.
This is !SMP code, then cpu=0 is ok.
From: Alexander Beregalov <a.beregalov@xxxxxxxxx>
Subject: [PATCH] x86: msr.h: fix build error
Fix this build error:
.../asm/msr.h: In function 'rdmsr_on_cpus':
.../asm/msr.h:248: error: request for member 'l' in something not a structure or union
.../asm/msr.h:248: error: request for member 'h' in something not a structure or union
.../asm/msr.h:248: error: too few arguments to function 'rdmsr_on_cpu'
.../asm/msr.h: In function 'wrmsr_on_cpus':
.../asm/msr.h:253: error: request for member 'l' in something not a structure or union
.../asm/msr.h:253: error: request for member 'h' in something not a structure or union
.../asm/msr.h:253: error: too few arguments to function 'wrmsr_on_cpu'
This is !SMP code so `cpu` should be 0.
Signed-off-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
---
arch/x86/include/asm/msr.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index e49c14e..fa082ba 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -243,14 +243,14 @@ static inline int wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h)
return 0;
}
static inline int rdmsr_on_cpus(const cpumask_t *m, u32 msr_no,
- struct msr **msrs)
+ struct msr *msrs)
{
- return rdmsr_on_cpu(msr_no, &(msrs[0].l), &(msrs[0].h));
+ return rdmsr_on_cpu(0, msr_no, &(msrs[0].l), &(msrs[0].h));
}
static inline int wrmsr_on_cpus(const cpumask_t *m, u32 msr_no,
- struct msr **msrs)
+ struct msr *msrs)
{
- return wrmsr_on_cpu(msr_no, msrs[0].l, msrs[0].h);
+ return wrmsr_on_cpu(0, msr_no, msrs[0].l, msrs[0].h);
}
static inline int rdmsr_safe_on_cpu(unsigned int cpu, u32 msr_no,
u32 *l, u32 *h)
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
