Re: INET_LRO as tristate and use from modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 22 Apr 2009 02:12:18 -0700 (PDT)

> From: Olof Johansson <olof@xxxxxxxxx>
> Date: Tue, 21 Apr 2009 14:33:19 -0500
> 
>> On Wed, Apr 22, 2009 at 12:23:03AM +0530, Subrata Modak wrote:
>>>   MODPOST 338 modules
>>> ERROR: ".lro_receive_skb" [drivers/net/pasemi_mac_driver.ko] undefined!
>>> ERROR: ".lro_flush_all" [drivers/net/pasemi_mac_driver.ko] undefined!
>>> WARNING: modpost: Found 1 section mismatch(es).
>>> To see full details build your kernel with:
>>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>>> make[1]: *** [__modpost] Error 1
>>> make: *** [modules] Error 2
>> 
>> This seems to be a problem with all tristate-capable drivers that use
>> LRO (and uses select INET_LRO in their Kconfig): INET_LRO is a tristate
>> and can thus be a module. Looks like it needs to be a bool instead?
> 
> Yes, making this a bool would be the easiest fix.
> 
> By why don't we get the same problem for PHYLIB?  It's also
> tristate and "select"'d by a whole slew of networking drivers.

I guess nobody has any idea...

I'll just make INET_LRO a bool to fix this.
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux