Hi Sam,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
We get these occasionally on powerpc builds - Usually from
EXPORT_SYMBOLS. Though I was hoping that using a newer compiler would
fix that (I am now compiling with gcc 4.4.0).
Direct cause is commit efbe795f5f63b74ed642e196518907355aa94bd7
("initconst adjustments").
OK, looking at the preprocessor output, I see we have a previous variable
(static match_table_t __initconst tokens) with __attribute__ ((__section__
(".init.rodata"))) but it is not const ... (This came from commit
a447c0932445f92ce6f4c1bd020f62c5097a7842 "vfs: Use const for kernel
parser table" which changed "tokens" from __initdata to __initconst. Not
using "const" seems deliberate, but the changelog does not include enough
information as to why.)
So, I will revert the above commit for today to allow it to be "improved"
by also fixing the tokens variable definition above. Of course there may
be other places where such mixed definitions exist.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
Attachment:
pgpzz9nEXJxzv.pgp
Description: PGP signature
