On Fri, May 1, 2009 at 8:19 AM, Benny Halevy <bhalevy@xxxxxxxxxxx> wrote:
> On May. 01, 2009, 6:22 +0300, Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:
>> On Fri, 2009-05-01 at 13:15 +1000, Stephen Rothwell wrote:
>>> Hi Trond,
>>>
>>> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>>>
>>> fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
>>> fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes
>>>
>>> Introduced by commit 63a93b4af49220c74757beb17b5617b72d912b6b ("nfs41:
>>> exchange_id operation"). This commit has been around for a while.
>>
>> Benny, Andy,
>>
>> Why are we preallocating 1k buffers on the stack for these things?
>> That's an insane amount of free space...
>>
>> If this is truly a realistic value (which I sincerely doubt), then the
>> right thing to do is to preallocate a page in which to store them.
>> Putting 1k arrays on the stack is just _wrong_.
>>
>> Trond
>>
>
> Ouch, struct nfs41_exchange_id_res contains
> struct server_owner server_owner;
> struct server_scope server_scope;
> each embedding a char [NFS4_OPAQUE_LIMIT] array
> which is 1K in length.
> Not only we should have preallocated these arrays dynamically,
> we actually throw them away.
> Therefore I suggest that until they are put to use
> we should just skip their xdr decoding, like we do
> for the implementation ID.
Yes, I agree. That is just wrong....
-->Andy
>
> Benny
>
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
