* Gautham R Shenoy <ego@xxxxxxxxxx> wrote:
> On Tue, Apr 21, 2009 at 10:27:06AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) produced this new
> > warning:
> >
> > kernel/sched.c: In function 'find_new_ilb':
> > kernel/sched.c:4355: warning: passing argument 1 of '__first_cpu' from incompatible pointer type
> >
> > Possibly caused by commit f711f6090a81cbd396b63de90f415d33f563af9b
> > ("sched: Nominate idle load balancer from a semi-idle package") from the
> > sched tree. Should this call to first_cpu be cpumask_first?
>
> Yes, it should be cpumask_first. Patch appended.
>
> -->
> sched: Replace first_cpu() with cpumask_first() in ILB nomination code.
>
> From: Gautham R Shenoy <ego@xxxxxxxxxx>
>
> For !(CONFIG_SCHED_MC || CONFIG_SCHED_SMT), find_new_ilb() nominates the
> Idle load balancer as the first cpu from the nohz.cpu_mask.
>
> This code uses the older API first_cpu(). Replace it with cpumask_first(),
> which is the correct API here.
>
> Signed-off-by: Gautham R Shenoy <ego@xxxxxxxxxx>
> ---
>
> kernel/sched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index bbf367d..6df8dd5 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -4344,7 +4344,7 @@ out_done:
> #else /* (CONFIG_SCHED_MC || CONFIG_SCHED_SMT) */
> static inline int find_new_ilb(int call_cpu)
> {
> - return first_cpu(nohz.cpu_mask);
> + return cpumask_first(nohz.cpu_mask);
Given that this is not an onstack cpumask the type mismatch is
harmless in effect but obviously needs fixed.
I've applied your fix to tip:sched/core - thanks guys.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
