Hi James, Today's linux-next build (powerpc allyesconfig) failed like this: drivers/scsi/fcoe/fcoe.c:982: error: __ksymtab_fcoe_fc_crc causes a section type conflict drivers/scsi/fcoe/fcoe.c:982: error: __ksymtab_fcoe_fc_crc causes a section type conflict Reverting commit 0c3cb56ec3321b23e9826cccf822470717be6e08 ("[SCSI] fcoe: cleans up libfcoe.h and adds fcoe.h for fcoe module") makes the error go away. I have no idea why - the only clue is that the only global declaration of fcoe_fc_crc() is removed by that commit. Using a different compiler version (4.1.2) also fixed the problem. I also had to revert commits 60390544fcc212e0657cf1eea639691d09651943 ("[SCSI] fcoe, libfc: fix double fcoe_softc memory alloc") and ba070644bff4390c965e99b1997f2cbec4157b46 ("[SCSI] fcoe, libfcoe: Add support for FIP. FCoE discovery and keep-alive") since they followed the one above. I wonder if that function even needs to be exported as it is only used withing the one file. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/
Attachment:
pgpbFa5vKLMR6.pgp
Description: PGP signature