Re: [PATCH] Re: Next March 25: net/netfilter/xt_LED build failure.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Subrata Modak wrote:
The following patch will solve the build problem reported by Sachin.
But would leave the following warnings. I hope we can ignore them:

net/netfilter/xt_LED.c: In function �led_timeout_callback�:
net/netfilter/xt_LED.c:78: warning: unused variable �ledinternal�
net/netfilter/xt_LED.c: In function �led_tg_check�:
net/netfilter/xt_LED.c:87: warning: unused variable �err�

Signed-Off-By: Subrata Modak<subrata@xxxxxxxxxxxxxxxxxx>
---

--- a/linux-2.6.29/net/netfilter/xt_LED.c	2009-03-25 18:38:08.000000000 +0530
+++ b/linux-2.6.29/net/netfilter/xt_LED.c	2009-03-25 18:26:55.000000000 +0530
@@ -99,6 +99,7 @@ static bool led_tg_check(const struct xt
ledinternal->netfilter_led_trigger.name = ledinfo->id; +#ifdef CONFIG_LEDS_TRIGGERS
...


Does this patch fix it?
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 2562d05..2c967e4 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -374,7 +374,7 @@ config NETFILTER_XT_TARGET_HL
 
 config NETFILTER_XT_TARGET_LED
 	tristate '"LED" target support'
-	depends on LEDS_CLASS
+	depends on LEDS_CLASS && LED_TRIGGERS
 	depends on NETFILTER_ADVANCED
 	help
 	  This option adds a `LED' target, which allows you to blink LEDs in

[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux