Re: [RFC 2/4] net: netfilter conntrack - add per-net functionality for DCCP protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Lezcano wrote:
Cyrill Gorcunov wrote:
Module specific data moved into per-net site and being allocated/freed
during net namespace creation/deletion.

Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
---
net/netfilter/nf_conntrack_proto_dccp.c | 148 ++++++++++++++++++++++++--------
 1 file changed, 111 insertions(+), 37 deletions(-)


static int __init nf_conntrack_proto_dccp_init(void)
 {
     int err;
- err = nf_conntrack_l4proto_register(&dccp_proto4);
+    err = register_pernet_gen_device(&dccp_net_id, &dccp_net_ops);

[ cut ]
Shouldn't it be register_pernet_gen_subsys ?
If you use register_pernet_gen_device, your subsystem will be deleted before the network devices and potentially you can receive a packet even if your subsystem is already freed.

Eric did a fix for tcp and icmp a few weeks ago. I thing its explanation is better than mine :)
it is the commit 6eb0777228f31932fc941eafe8b08848466630a1 for net-2.6

Thanks.
 -- Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux