* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote: > On Fri, Mar 6, 2009 at 7:01 AM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote: > > On 3/6/09, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > >> Hi all, > >> > >> Today's linux-next build (x86_64 allmodconfig) produced this warning: > >> > >> In file included from drivers/char/epca.c:49: > >> drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined > >> In file included from include/linux/linkage.h:5, > >> from include/linux/kernel.h:11, > >> from arch/x86/include/asm/system.h:10, > >> from arch/x86/include/asm/processor.h:17, > >> from include/linux/prefetch.h:14, > >> from include/linux/list.h:6, > >> from include/linux/module.h:9, > >> from drivers/char/epca.c:29: > >> arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the > >> previous definition > >> > >> Probably introduced by commit 95695547a7db44b88a7ee36cf5df188de267e99e > >> ("x86: asm linkage - introduce GLOBAL macro") from the x86 tree. > >> -- > >> Cheers, > >> Stephen Rothwell sfr@xxxxxxxxxxxxxxxx > >> http://www.canb.auug.org.au/~sfr/ > >> > > > > Thanks Stephen, i will take a look. Iirc the same macro used as well > > in ia64 arch, weird. > > > > I've just checked the sources -- it seems some definitions in > arch/x86/include/asm/linkage.h should be guarded by > __ASSEMBLY__ (ie -- __ALIGN, __ALIGN_STR and eventually > GLOBAL). I'll make a patch today evening (can't get access to > linux machine right now). Ingo? sure, that's fine. It's not a fatal warning. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html