On Thu, Feb 19, 2009 at 06:40, Rusty Russell wrote: > On Thursday 19 February 2009 12:25:13 Mike Frysinger wrote: >> > +char *strncpy(char *dest, const char *src, size_t n); >> > #define strncpy __inline_strncpy >> > #include <asm/string.h> >> > #undef strncpy >> >> size_t is not a builtin type so there needs to be a linux/types.h >> include right above these two prototypes. then things build up fine >> for me. > > OK, this time for sure! > > > blackfin: allow usage of string functions in linux/string.h > > In introducing a trivial "strstarts()" function in linux/string.h, we > hit the following error on blackfin: > > file included from include/linux/bitmap.h:9, > from include/linux/nodemask.h:90, > from include/linux/mmzone.h:17, > from include/linux/gfp.h:5, > from include/linux/kmod.h:23, > from include/linux/module.h:14, > from arch/blackfin/lib/strncmp.c:14: > include/linux/string.h: In function 'strstarts': > include/linux/string.h:124: error: implicit declaration of function 'strncmp' > > Because when including asm/string.h from arch/blackfin/lib/strncmp.c, > we don't declare the string op we are about to define, and > linux/string.h barfs. > > The fix is to declare the function whose definition we steal via the > #define trick. I do this for all of them, so this won't bite us in > future. > > Reported-by: linux-next > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> Tested-by: Mike Frysinger <vapier@xxxxxxxxxx> -mike -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
