* Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Fri, Feb 06, 2009 at 08:59:01PM +0530, Jaswinder Singh Rajput wrote: > > On Fri, 2009-02-06 at 15:55 +0100, Ingo Molnar wrote: > > > * KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: > > > > > > > > > Index: b/arch/ia64/include/asm/fpu.h > > > > > > =================================================================== > > > > > > --- a/arch/ia64/include/asm/fpu.h > > > > > > +++ b/arch/ia64/include/asm/fpu.h > > > > > > @@ -6,7 +6,7 @@ > > > > > > * David Mosberger-Tang <davidm@xxxxxxxxxx> > > > > > > */ > > > > > > > > > > > > -#include <linux/types.h> > > > > > > +#include <asm/types.h> > > > > > > > > > > > > > > > > No , we do not even need asm/types.h > > > > > > > > > > Subject: [PATCH] Neither asm/types.h nor linux/types.h is not required > > > > > for arch/ia64/include/asm/fpu.h > > > > > > > > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx> > > > > > > > > ok. I confirmed. > > > > Tested-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > > > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > > > > > Thanks. > > > > > > Jaswinder, mind adding these tags to the commit and sending a pull request > > > with all fixes? > > > > The following changes since commit 0b86a4e34d885e734a4c4e46293376f3f1c639eb: > > Ingo Molnar (1): > > Merge branch 'core/header-fixes' of git://git.kernel.org/.../jaswinder/linux-2.6-tip into core/header-fixes > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git core/header-fixes > > > > Jaswinder Singh Rajput (2): > > Neither asm/types.h nor linux/types.h is required for arch/ia64/include/asm/fpu.h > > make linux/types.h as assembly safe > > I continue to disagree with the need for the second patch. But have not replied to my mail about that so far. Why is it wrong to make types.h an assembly-invariant? It is positively helpful for mixed-mode headers and has no downsides whatsoever. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
