On Thursday 05 February 2009 13:02:03 Ingo Molnar wrote:
>
> * Thomas Renninger <trenn@xxxxxxx> wrote:
>
> > Signed-off-by: Thomas Renninger <trenn@xxxxxxx>
> > ---
> > arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 12 ++++++------
> > 1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> > index 83515f1..5aa832f 100644
> > --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> > +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> > @@ -1247,12 +1247,12 @@ static int __cpuinit powernowk8_cpu_init(struct
cpufreq_policy *pol)
> > * thing gets introduced
> > */
> > if (!print_once) {
> > - WARN_ONCE(1, KERN_ERR FW_BUG PFX "Your BIOS "
> > - "does not provide ACPI _PSS objects "
> > - "in a way that Linux understands. "
> > - "Please report this to the Linux ACPI"
> > - " maintainers and complain to your "
> > - "BIOS vendor.\n");
> > + printk(KERN_ERR FW_BUG PFX "Your BIOS "
> > + "does not provide ACPI _PSS objects "
> > + "in a way that Linux understands. "
> > + "Please report this to the Linux ACPI"
> > + " maintainers and complain to your "
> > + "BIOS vendor.\n");
> > print_once++;
>
> hm, why the open-coded WARN_ONCE? (which print_once flag + the printk in
> essence is)
Looking at WARN() again:
#ifndef __WARN
#ifndef __ASSEMBLY__
extern void warn_slowpath(const char *file, const int line,
const char *fmt, ...) __attribute__((format(printf, 3, 4)));
#define WANT_WARN_ON_SLOWPATH
#endif
#define __WARN() warn_slowpath(__FILE__, __LINE__, NULL)
#define __WARN_printf(arg...) warn_slowpath(__FILE__, __LINE__, arg)
#else
#define __WARN_printf(arg...) do { printk(arg); __WARN(); } while (0)
#endif
WARN_ONCE does throw a backtrace (warn_slowpath does) or I missed
something...
Thus WARN_ONCE makes a big difference to printk_once() (which does not
exist? but would be neat...) and prints out the backtrace, right?
Thanks,
Thomas
>
> So please use WARN_ONCE(), and indent it all one tab to the left which will
> solve at least part of that ugly 6-line split up thing. And if it's a
> WARN_ONCE() then kerneloops.org will pick it up too.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
