Alan Cox wrote: >> drivers/net/8390p.o: In function `ei_get_stats': >> (.text+0x1050): multiple definition of `ei_get_stats' >> drivers/net/8390.o:(.text+0xe20): first defined here >> drivers/net/8390p.o: In function `ei_start_xmit': >> (.text+0x1100): multiple definition of `ei_start_xmit' >> drivers/net/8390.o:(.text+0xef0): first defined here >> drivers/net/8390p.o: In function `ei_tx_timeout': >> (.text+0xec0): multiple definition of `ei_tx_timeout' >> drivers/net/8390.o:(.text+0xce0): first defined here >> drivers/net/8390p.o: In function `ei_set_multicast_list': >> (.text+0x1000): multiple definition of `ei_set_multicast_list' >> drivers/net/8390.o:(.text+0xea0): first defined here >> make[2]: *** [drivers/net/built-in.o] Error 1 >> >> and none of these functions is static in lib8390.c. > > They seem to be just fine in the base tree, so somebody has merged > something stoopid. > > > */ > > static int ei_start_xmit(struct sk_buff *skb, struct net_device *dev) > { OK, ack that, thanks. Looks like it's due to CONFIG_COMPAT_NET_DEV_OPS. Dave, no need to drop my hp-plus driver patch. ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html