On Mon, Nov 10, 2008 at 04:29:41PM +1100, Stephen Rothwell wrote: > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > fs/proc/base.c:2547: error: 'pid_stack' undeclared here (not in a function) > > Caused by an interaction of commits > 078e9901c02d4899db5b24f708b8dfbca8935891 ("stacktrace: > add /proc/<pid>/stack to dump task's stack trace") and > 35f0b5fd7fab907a1119eaa614d9b24e5e225755 ("stacktrace: > convert /proc/<pid>/stack to seqfiles") from the tip-core tree with commit > 5d8880e3e0fb96459c652ac5e1504b90c949b3b9 ("proc: remove '##' usage") from > the proc tree. > > The former added a new usage of INF (which the second converted to a > ONE). I added the following patch to the merge of the proc tree and can > carry it. Time to steal this /proc/*/stack from Ingo. :-) > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -2544,7 +2544,7 @@ static const struct pid_entry tgid_base_stuff[] = { > INF("wchan", S_IRUGO, proc_pid_wchan), > #endif > #ifdef CONFIG_STACKTRACE > - ONE("stack", S_IRUSR, pid_stack), > + ONE("stack", S_IRUSR, proc_pid_stack), correct -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html