2008/10/23 Alexey Dobriyan <adobriyan@xxxxxxxxx>: > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote: >> When tracing is enabled, some arch have included <linux/irqflags.h> >> on their <asm/system.h> but others like alpha or m68k don't. >> >> Build error on alpha: >> >> kernel/trace/trace.c: In function 'tracing_generic_entry_update': >> kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags' >> kernel/trace/trace.c: In function 'tracing_cpumask_write': >> kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable' >> kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable' >> kernel/trace/trace.c: In function 'trace_die_handler': >> kernel/trace/trace.c:3039: error: 'DIE_OOPS' undeclared (first use in this function) >> >> Build error on m68k: >> http://kisskb.ellerman.id.au/kisskb/buildresult/50641/ >> >> >> Include it on kernel/trace/trace.c >> >> Reported-by: Alexey Dobriyan <adobriyan@xxxxxxxxx> >> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx> >> --- >> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c >> index 78d5661..deb9684 100644 >> --- a/kernel/trace/trace.c >> +++ b/kernel/trace/trace.c >> @@ -34,6 +34,7 @@ >> >> #include <linux/stacktrace.h> >> #include <linux/ring_buffer.h> >> +#include <linux/irqflags.h> > > Sure, except it doesn't fix anything. > Really? You mean only m68k or even on alpha? -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html