On Wed, 15 Oct 2008, Stephen Rothwell wrote: > > +#ifndef NO_IRQ > +#define NO_IRQ 0 > +#endif Btw, as to why not do this idiocy, just grep for it. We have several drivers that try to do something this stupid. Don't take my word for it? Look for them. And see them do things like - drivers/scsi/arm/fas216.h: #ifndef NO_IRQ #define NO_IRQ 255 #endif - drivers/pcmcia/pd6729.c (really interesting): #ifndef NO_IRQ #define NO_IRQ ((unsigned int)(0)) #endif - drivers/rtc/rtc-m48t59.c: #ifndef NO_IRQ #define NO_IRQ (-1) #endif so please don't add yet another version to the insanity. Just mark anything with NO_IRQ as BROKEN or ARM-specific, or something. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
