From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
microcode_amd.c uses ">> 32" on a 32-bit value, so gcc warns about that.
The code could use something like this *untested* patch.
linux-next-20080821/arch/x86/kernel/microcode_amd.c:229: warning: right shift count >= width of type
Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
---
arch/x86/kernel/microcode_amd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-next-20080821.orig/arch/x86/kernel/microcode_amd.c
+++ linux-next-20080821/arch/x86/kernel/microcode_amd.c
@@ -216,6 +216,7 @@ static void apply_microcode_amd(int cpu)
unsigned int rev;
int cpu_num = raw_smp_processor_id();
struct ucode_cpu_info *uci = ucode_cpu_info + cpu_num;
+ unsigned long addr;
/* We should bind the task to the CPU */
BUG_ON(cpu_num != cpu);
@@ -225,10 +226,9 @@ static void apply_microcode_amd(int cpu)
spin_lock_irqsave(µcode_update_lock, flags);
- edx = (unsigned int)(((unsigned long)
- &(uci->mc.mc_amd->hdr.data_code)) >> 32);
- eax = (unsigned int)(((unsigned long)
- &(uci->mc.mc_amd->hdr.data_code)) & 0xffffffffL);
+ addr = (unsigned long)&uci->mc.mc_amd->hdr.data_code;
+ edx = (unsigned int)(((unsigned long)upper_32_bits(addr)));
+ eax = (unsigned int)(((unsigned long)lower_32_bits(addr)));
asm volatile("movl %0, %%ecx; wrmsr" :
: "i" (0xc0010020), "a" (eax), "d" (edx) : "ecx");
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
