At Wed, 13 Aug 2008 15:37:15 +0200, I wrote: > > At Wed, 13 Aug 2008 14:08:11 +0100, > Alan Cox wrote: > > > > > When re-starting X, it complains that it cannot change to VT7. > > > Via strace, > > > > Does this fix it > > > > @@ -838,6 +839,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) > > void __cleanup_signal(struct signal_struct *sig) > > { > > exit_thread_group_keys(sig); > > + tty_kref_put(sig->tty); > > kmem_cache_free(signal_cachep, sig); > > } > > Thanks, will give it a try. > > The above can't be applied as is to next tree, so the following is > applied instead. It oopsed with udevd at the early boot stage... BUG: unable to handle kernel paging request at 4455003d IP: [<c01e9b69>] kref_put+0x29/0x44 *pde = 00000000 Oops: 0002 [#1] SMP last sysfs file: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/timeout Modules linked in: sd_mod crc_t10dif uhci_hcd ehci_hcd usbcore edd ext3 mbcache jbd fan ata_piix libata scsi_mod dock thermal processor Pid: 638, comm: udevd Not tainted (2.6.27-rc3-next-20080813-next #1) EIP: 0060:[<c01e9b69>] EFLAGS: 00010202 CPU: 1 EIP is at kref_put+0x29/0x44 EAX: 4455003d EBX: 4455003d ECX: c2005b8c EDX: 00000040 ESI: c023b9ed EDI: fffffdff EBP: f6adff08 ESP: f6adff00 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 Process udevd (pid: 638, ti=f6ade000 task=f6ac8000 task.ti=f6ade000) Stack: f6a3a200 f6abeec0 f6adff10 c023c2dc f6adff1c c0123d30 f6abec90 f6adff58 c01252cf f6a3a200 00000082 f6adffb8 bfcc26a8 01200011 00000000 f6abee80 f6ac8000 f6abe080 00000000 f6adffb8 bfcc26a8 00000000 f6adff98 c012546f Call Trace: [<c023c2dc>] ? tty_kref_put+0x14/0x16 [<c0123d30>] ? __cleanup_signal+0x11/0x20 [<c01252cf>] ? copy_process+0xde7/0xec6 [<c012546f>] ? do_fork+0xc1/0x1ff [<c0102447>] ? sys_clone+0x25/0x2a [<c010399b>] ? sysenter_do_call+0x12/0x2f ======================= Code: 5d c3 55 89 e5 56 89 d6 85 f6 ba 40 00 00 00 53 89 c3 74 0d 81 fe 63 cd 17 c0 75 0f ba 41 00 00 00 b8 aa 18 3c c0 e8 36 bf f3 ff <f0> ff 0b 0f 94 c0 31 d2 84 c0 74 09 89 d8 ff d6 ba 01 00 00 00 EIP: [<c01e9b69>] kref_put+0x29/0x44 SS:ESP 0068:f6adff00 ---[ end trace 2b6d2df1e77a968c ]--- Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html